Weapon drop callback + Fix for weapons still dropping #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
okay so I tested the code callback now and the flag, and both work havent tested in specifically Infection though |
ASpoonPlaysGames
requested changes
Aug 26, 2023
Northstar.CustomServers/mod/scripts/vscripts/mp/_codecallbacks.gnut
Outdated
Show resolved
Hide resolved
Co-authored-by: Jack <[email protected]>
…hstarMods into weapon-drop-callback
ASpoonPlaysGames
approved these changes
Aug 26, 2023
ASpoonPlaysGames
added
the
needs testing
EladNLG
approved these changes
Aug 30, 2023
ASpoonPlaysGames
requested changes
Sep 2, 2023
Northstar.CustomServers/mod/scripts/vscripts/mp/_codecallbacks.gnut
Outdated
Show resolved
Hide resolved
Northstar.CustomServers/mod/scripts/vscripts/mp/_codecallbacks.gnut
Outdated
Show resolved
Hide resolved
Co-authored-by: Jack <[email protected]>
Co-authored-by: Jack <[email protected]>
Co-authored-by: Jack <[email protected]>
Co-authored-by: Jack <[email protected]>
ASpoonPlaysGames
approved these changes
Sep 16, 2023
|
Tested on infection with latest northstar version. Can confirm that this works as intended, executions no longer bypass the weapon drop flag. |
GeckoEidechse
added
READY TO MERGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of making this PR its untested.
This adds a callback for when a gun gets dropped, this is just an implementation of the already existing CodeCallback.
It at the same time fixes #613 and is a better #617 , it removed the callback for deleting the dropped gun.
Closes #613